Just so. Your points are well-taken, but even if she was not consciously wanting to cruel. Never mind that she is emotionally manipulative, entirely apart from what do appear to be some genuine (and warped) feelings for Indy. As Henry says, "Elsa never really believed in the Grail; she thought she'd found the prize." If we accept the faith part of the narrative, and for the moment, I shall, then her lack of genuine belief in what the Grail stands for religiously is what does not allow her to see the true meaning of the "eternal life" the Grail conveys. If we do not accept the faith portion of this, and look at a more secular notion of redemption, we can argue that despite Elsa's concern about Henry being shot and her assistance in the death of Donovan (which I stand with you in believing), her motives are not pure, and that even if there is a way to make up for her siding with the Nazis and appearing with Hitler on the highest level, what she does doesn't approach that.